linux-kernel - Re: [PATCH v10 1/3] usb: gadget: function: move u_f.h to include/linux/usb/func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs4JRPR9CKWX_hWb@pengutronix.de>
Date: Tue, 27 Aug 2024 19:13:40 +0200
From: Michael Grzeschik <mgr@...gutronix.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: andrzej.p@...labora.com, asmadeus@...ewreck.org, corbet@....net,
	ericvh@...nel.org, gregkh@...uxfoundation.org,
	kernel@...gutronix.de, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux_oss@...debyte.com, lucho@...kov.net, v9fs@...ts.linux.dev
Subject: Re: [PATCH v10 1/3] usb: gadget: function: move u_f.h to
 include/linux/usb/func_utils.h

On Tue, Aug 27, 2024 at 06:46:39PM +0200, Christophe JAILLET wrote:
>Le 26/08/2024 à 23:47, Michael Grzeschik a écrit :
>>We move the func_utils.h header to include/linux/usb to be
>>able to compile function drivers outside of the
>>drivers/usb/gadget/function directory.
>>
>>Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@...lic.gmane.org>
>>
>>---
>>v9 -> v10:
>>   - respect alphabetical order
>>   - correctly changed filename in func_utils.h itself
>>
>
>...
>
>>index e313c3b8dcb19..e7b69e3145c07 100644
>>--- a/drivers/usb/gadget/u_f.h
>>+++ b/include/linux/usb/func_utils.h
>>@@ -1,6 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  /*
>>- * u_f.h
>>+ * func_utils.h
>>   *
>>   * Utility definitions for USB functions
>>   *
>>
>
>Maybe the include guard could be updated as-well?
>
>By include guard I mean:
>
>	#ifndef __U_F_H__
>	#define __U_F_H__
>	...
>	#endif /* __U_F_H__ */
>
>s/__U_F_H__/_FUNC_UTILS_H_/ or something like that.
>
>CJ
>

Doh! I missed that but will spin another round!

Thanks,
Michael



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)