linux-kernel - Re: [PATCH v10 2/3] net/9p/usbg: Add new usb gadget function transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408302200.rlcB6d6K-lkp@intel.com>
Date: Fri, 30 Aug 2024 23:15:40 +0800
From: kernel test robot <lkp@...el.com>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
	v9fs@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	kernel@...gutronix.de,
	Michael Grzeschik <m.grzeschik@...gutronix.de>
Subject: Re: [PATCH v10 2/3] net/9p/usbg: Add new usb gadget function
 transport

Hi Michael,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-linus]
[also build test WARNING on linus/master v6.11-rc5]
[cannot apply to usb/usb-testing usb/usb-next ericvh-v9fs/for-next next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Grzeschik/net-9p-usbg-Add-new-usb-gadget-function-transport/20240827-064810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus
patch link:    https://lore.kernel.org/r/20240116-ml-topic-u9p-v10-2-a85fdeac2c52%40pengutronix.de
patch subject: [PATCH v10 2/3] net/9p/usbg: Add new usb gadget function transport
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20240830/202408302200.rlcB6d6K-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408302200.rlcB6d6K-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408302200.rlcB6d6K-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/9p/trans_usbg.c: In function 'p9_usbg_create':
>> net/9p/trans_usbg.c:373:30: warning: variable 'f' set but not used [-Wunused-but-set-variable]
     373 |         struct usb_function *f;
         |                              ^


vim +/f +373 net/9p/trans_usbg.c

   368	
   369	static int p9_usbg_create(struct p9_client *client, const char *devname, char *args)
   370	{
   371		struct f_usb9pfs_dev *dev;
   372		struct f_usb9pfs *usb9pfs;
 > 373		struct usb_function *f;
   374		int ret = -ENOENT;
   375		int found = 0;
   376	
   377		if (!devname)
   378			return -EINVAL;
   379	
   380		guard(mutex)(&usb9pfs_lock);
   381	
   382		list_for_each_entry(dev, &usbg_instance_list, usb9pfs_instance) {
   383			if (!strncmp(devname, dev->tag, strlen(devname))) {
   384				if (!dev->inuse) {
   385					dev->inuse = true;
   386					found = 1;
   387					break;
   388				}
   389				ret = -EBUSY;
   390				break;
   391			}
   392		}
   393	
   394		if (!found) {
   395			pr_err("no channels available for device %s\n", devname);
   396			return ret;
   397		}
   398	
   399		usb9pfs = dev->usb9pfs;
   400		if (!usb9pfs)
   401			return -EINVAL;
   402	
   403		f = &usb9pfs->function;
   404	
   405		client->trans = (void *)usb9pfs;
   406		if (!usb9pfs->in_req)
   407			client->status = Disconnected;
   408		else
   409			client->status = Connected;
   410		usb9pfs->client = client;
   411	
   412		client->trans_mod->maxsize = usb9pfs->buflen;
   413	
   414		complete(&usb9pfs->received);
   415	
   416		return 0;
   417	}
   418	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki