linux-kernel - [PATCH] clk: Delete init for local variable "best_crent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_EC61FECEE03D06AE0D29C514581901BDFB09@qq.com>
Date: Wed, 28 Aug 2024 01:21:10 +0800
From: jiping huang <huangjiping95@...com>
To: mturquette@...libre.com,
	sboyd@...nel.org
Cc: linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	jiping huang <huangjiping95@...com>
Subject: [PATCH] clk: Delete init for local variable "best_crent_rate".

  I'm sorry, my last submission may not expressed it clearly, and there \
is an error delete. Therefore, I would like to generate a new patch and \
explanations.
  Actually, it is, the local variable 'best_crent_rate' is only used in \
line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \
if the "if (clk_core_can_round (core))" branch condition in line 2306 \
is true, the value of the local variable "best_crent_rate" will be \
updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
it will be directly returned in the "else if" branch in line 2325 and the \
"else" branch in line 2329.
  In summary, it is unnecessary to store the "parent ->rate" value in \
"best_crent_rate" in line 2301.
  Thank you for your precious time!

Signed-off-by: jiping huang <huangjiping95@...com>

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 8cca52be993f..b6ff88f63bc4 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2297,8 +2297,6 @@ static struct clk_core *clk_calc_new_rates(struct clk_core *core,

 	/* save parent rate, if it exists */
 	parent = old_parent = core->parent;
-	if (parent)
-		best_parent_rate = parent->rate;

 	clk_core_get_boundaries(core, &min_rate, &max_rate);

-- 
2.34.1