linux-kernel - Re: [PATCH] clk: Delete init for local variable "best_crent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f670049f3110f2be74f28f09e277b4e.sboyd@kernel.org>
Date: Tue, 27 Aug 2024 10:40:09 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: jiping huang <huangjiping95@...com>, mturquette@...libre.com
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, jiping huang <huangjiping95@...com>
Subject: Re: [PATCH] clk: Delete init for local variable "best_crent_rate".

Quoting jiping huang (2024-08-27 10:21:10)
>   I'm sorry, my last submission may not expressed it clearly, and there \
> is an error delete. Therefore, I would like to generate a new patch and \
> explanations.
>   Actually, it is, the local variable 'best_crent_rate' is only used in \
> line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \
> if the "if (clk_core_can_round (core))" branch condition in line 2306 \
> is true, the value of the local variable "best_crent_rate" will be \
> updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
> it will be directly returned in the "else if" branch in line 2325 and the \
> "else" branch in line 2329.
>   In summary, it is unnecessary to store the "parent ->rate" value in \
> "best_crent_rate" in line 2301.
>   Thank you for your precious time!

Please read the docs on how to submit patches. Especially the part about
describing your change[1]. For example, "best_crent_rate" doesn't exist.
Also, look at other commits for guidance on how to write your commit
text. Thanks!

[1] https://docs.kernel.org/process/submitting-patches.html#describe-your-changes