linux-kernel - Re: [PATCH V4 11/12] bnxt_en: Add TPH support in BNXT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827120544.383a1eef@kernel.org>
Date: Tue, 27 Aug 2024 12:05:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andy Gospodarek <andrew.gospodarek@...adcom.com>
Cc: Wei Huang <wei.huang2@....com>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 netdev@...r.kernel.org, Jonathan.Cameron@...wei.com, helgaas@...nel.org,
 corbet@....net, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, alex.williamson@...hat.com, michael.chan@...adcom.com,
 ajit.khaparde@...adcom.com, somnath.kotur@...adcom.com,
 manoj.panicker2@....com, Eric.VanTassell@....com,
 vadim.fedorenko@...ux.dev, horms@...nel.org, bagasdotme@...il.com,
 bhelgaas@...gle.com, lukas@...ner.de, paul.e.luse@...el.com,
 jing2.liu@...el.com
Subject: Re: [PATCH V4 11/12] bnxt_en: Add TPH support in BNXT driver

On Tue, 27 Aug 2024 10:50:51 -0400 Andy Gospodarek wrote:
> > The merge window is in 3 weeks or so, so this can wait.  
> 
> Are you asking for the patch for this feature to include the queue
> stop/start instead of this? 

Yes, indeed.

> I just checked linux-pci and it does have bnxt_queue_stop/bnxt_queue_start.
>
> > I'm worried we'll find out later that the current queue reset
> > implementation in bnxt turns out to be insufficient. And we'll
> > be stuck with yet another close/open in this driver.  
> 
> The queue reset _has_ to work.  We will ensure that it does and fix any
> problems found.  Note that these have been under test already internally
> and fixes are/will be posted to the list as they are made.  Holding this
> patch because an API that it uses might not work seems odd.

Not holding because API may not work, holding because (I thought) 
API isn't in place at all. If bnxt_queue_stop/bnxt_queue_start are in
linux-pci please rewrite the patch to use those and then all clear 
from my PoV.