linux-kernel - Re: [PATCH V4 11/12] bnxt_en: Add TPH support in BNXT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikctGq7Mg-7htmj=FUKcTXhaHsujJ32VCKnwDpKqNVv0A@mail.gmail.com>
Date: Tue, 27 Aug 2024 12:20:34 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andy Gospodarek <andrew.gospodarek@...adcom.com>, Wei Huang <wei.huang2@....com>, 
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org, 
	Jonathan.Cameron@...wei.com, helgaas@...nel.org, corbet@....net, 
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	alex.williamson@...hat.com, ajit.khaparde@...adcom.com, 
	somnath.kotur@...adcom.com, manoj.panicker2@....com, Eric.VanTassell@....com, 
	vadim.fedorenko@...ux.dev, horms@...nel.org, bagasdotme@...il.com, 
	bhelgaas@...gle.com, lukas@...ner.de, paul.e.luse@...el.com, 
	jing2.liu@...el.com
Subject: Re: [PATCH V4 11/12] bnxt_en: Add TPH support in BNXT driver

On Tue, Aug 27, 2024 at 12:05 PM Jakub Kicinski <kuba@...nel.org> wrote:

> Not holding because API may not work, holding because (I thought)
> API isn't in place at all. If bnxt_queue_stop/bnxt_queue_start are in
> linux-pci please rewrite the patch to use those and then all clear
> from my PoV.

To be clear, the API is available in the linux-pci tree but the recent
patch from David to check for proper FW support is only in net-next:

97cbf3d0accc ("bnxt_en: only set dev->queue_mgmt_ops if supported by FW")

So we'll need to add this check for TPH also once the 2 trees are merged.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)