linux-kernel - [PATCH] usb: dwc3: gadget: Fix TX FIFO size for HS ISOC endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827054956.28241-1-quic_akakum@quicinc.com>
Date: Tue, 27 Aug 2024 11:19:56 +0530
From: Akash Kumar <quic_akakum@...cinc.com>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Jing Leng <jleng@...arella.com>, Felipe Balbi
	<balbi@...nel.org>,
        Jack Pham <quic_jackp@...cinc.com>, <kernel@...cinc.com>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Laurent Pinchart
	<laurent.pinchart@...asonboard.com>,
        Daniel Scally
	<dan.scally@...asonboard.com>
CC: Vijayavardhan Vennapusa <quic_vvreddy@...cinc.com>,
        Krishna Kurapati
	<quic_kriskura@...cinc.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Akash Kumar <quic_akakum@...cinc.com>
Subject: [PATCH] usb: dwc3: gadget: Fix TX FIFO size for HS ISOC endpoints

Use 2K TX FIFO size for low-resolution UVC cameras to support the
maximum possible UVC instances. Restrict 2K TX FIFO size based on
the minimum maxburst required to run low-resolution UVC cameras.

Signed-off-by: Akash Kumar <quic_akakum@...cinc.com>
---
 drivers/usb/dwc3/gadget.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 89fc690fdf34..f342ccda6705 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -788,6 +788,10 @@ static int dwc3_gadget_resize_tx_fifos(struct dwc3_ep *dep)
 	     usb_endpoint_xfer_isoc(dep->endpoint.desc)) && DWC3_IP_IS(DWC31))
 		num_fifos = dwc->tx_fifo_resize_max_num;
 
+	if (dep->endpoint.maxburst <= 1 &&
+	    usb_endpoint_xfer_isoc(dep->endpoint.desc))
+		num_fifos = 2;
+
 	/* FIFO size for a single buffer */
 	fifo = dwc3_gadget_calc_tx_fifo_size(dwc, 1);
 
-- 
2.17.1