linux-kernel - RE: [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <011201daf845$2d7846e0$8868d4a0$@samsung.com>
Date: Tue, 27 Aug 2024 14:51:35 +0900
From: 김기웅 <kwmad.kim@...sung.com>
To: "'Bean Huo'" <huobean@...il.com>, <linux-scsi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alim.akhtar@...sung.com>,
	<avri.altman@....com>, <bvanassche@....org>, <jejb@...ux.ibm.com>,
	<martin.petersen@...cle.com>, <beanhuo@...ron.com>,
	<adrian.hunter@...el.com>, <h10.kim@...sung.com>, <hy50.seo@...sung.com>,
	<sh425.lee@...sung.com>, <kwangwon.min@...sung.com>,
	<junwoo80.lee@...sung.com>, <wkon.kim@...sung.com>
Subject: RE: [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS
 value

> +static enum utp_ocs exynos_ufs_override_cqe_ocs(enum utp_ocs ocs) {
> +	if (ocs == OCS_ABORTED)
> +		ocs = OCS_INVALID_COMMAND_STATUS;
> +	return ocs;
> +}
> 
> 
> I wonder if you have considered the case where the command is aborted
> by the host software or by the device itself?

I mean by the host software and Exynos host reports OCS_ABORTED only for the case when MCQ is enabled.

> 
> If you change OCS to OCS_INVALID_COMMAND_STATUS, there will report a
> DID_REQUEUE to SCSI.

Yes. That's what I meant, in order to process them properly after UFS initialization.

> 
> 
> Kind regards,
> Bean

Thank you.