linux-kernel - Re: [PATCH] thermal: sprd: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d335fd2a-9ab6-4f91-aa11-559deb419433@linux.alibaba.com>
Date: Tue, 27 Aug 2024 16:35:45 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Huan Yang <link@...o.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH] thermal: sprd: Use devm_clk_get_enabled() helpers



On 2024/8/20 17:44, Huan Yang wrote:
> The devm_clk_get_enabled() helpers:
>      - call devm_clk_get()
>      - call clk_prepare_enable() and register what is needed in order to
>       call clk_disable_unprepare() when needed, as a managed resource.
> 
> This simplifies the code and avoids the calls to clk_disable_unprepare().
> 
> Signed-off-by: Huan Yang <link@...o.com>

Thanks. LGTM.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/thermal/sprd_thermal.c | 14 +++-----------
>   1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 874192546548..dfd1d529c410 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -359,21 +359,17 @@ static int sprd_thm_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	thm->clk = devm_clk_get(&pdev->dev, "enable");
> +	thm->clk = devm_clk_get_enabled(&pdev->dev, "enable");
>   	if (IS_ERR(thm->clk)) {
>   		dev_err(&pdev->dev, "failed to get enable clock\n");
>   		return PTR_ERR(thm->clk);
>   	}
>   
> -	ret = clk_prepare_enable(thm->clk);
> -	if (ret)
> -		return ret;
> -
>   	sprd_thm_para_config(thm);
>   
>   	ret = sprd_thm_cal_read(np, "thm_sign_cal", &val);
>   	if (ret)
> -		goto disable_clk;
> +		return ret;
>   
>   	if (val > 0)
>   		thm->ratio_sign = -1;
> @@ -382,7 +378,7 @@ static int sprd_thm_probe(struct platform_device *pdev)
>   
>   	ret = sprd_thm_cal_read(np, "thm_ratio_cal", &thm->ratio_off);
>   	if (ret)
> -		goto disable_clk;
> +		return ret;
>   
>   	for_each_child_of_node(np, sen_child) {
>   		sen = devm_kzalloc(&pdev->dev, sizeof(*sen), GFP_KERNEL);
> @@ -439,8 +435,6 @@ static int sprd_thm_probe(struct platform_device *pdev)
>   
>   of_put:
>   	of_node_put(sen_child);
> -disable_clk:
> -	clk_disable_unprepare(thm->clk);
>   	return ret;
>   }
>   
> @@ -526,8 +520,6 @@ static void sprd_thm_remove(struct platform_device *pdev)
>   		devm_thermal_of_zone_unregister(&pdev->dev,
>   						thm->sensor[i]->tzd);
>   	}
> -
> -	clk_disable_unprepare(thm->clk);
>   }
>   
>   static const struct of_device_id sprd_thermal_of_match[] = {