linux-kernel - Re: cachefiles: fix dentry leak in cachefiles_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73e33aaa-dfde-4afd-b6f5-650f89e6aa84@web.de>
Date: Tue, 27 Aug 2024 10:34:13 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Baokun Li <libaokun@...weicloud.com>, netfs@...ts.linux.dev,
 linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 David Howells <dhowells@...hat.com>, Jeff Layton <jlayton@...nel.org>
Cc: stable@...nel.org, LKML <linux-kernel@...r.kernel.org>,
 Christian Brauner <brauner@...nel.org>,
 Gao Xiang <hsiangkao@...ux.alibaba.com>, Hou Tao <houtao1@...wei.com>,
 Jingbo Xu <jefflexu@...ux.alibaba.com>, Yang Erkun <yangerkun@...wei.com>,
 Yu Kuai <yukuai3@...wei.com>, Zizhi Wo <wozizhi@...wei.com>,
 Baokun Li <libaokun1@...wei.com>
Subject: Re: cachefiles: fix dentry leak in cachefiles_open_file()

>> …
>>> Add the missing dput() to cachefiles_open_file() for a quick fix.
>> I suggest to use a goto chain accordingly.
…
> Thanks for the suggestion, but I think the current solution is simple enough

Yes, of course (in principle).


> that we don't need to add a label to it.

I came along other software design expectations.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11-rc5#n526

Regards,
Markus