linux-kernel - Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <988772.1724850113@warthog.procyon.org.uk>
Date: Wed, 28 Aug 2024 14:01:53 +0100
From: David Howells <dhowells@...hat.com>
To: Baokun Li <libaokun@...weicloud.com>
Cc: dhowells@...hat.com, Markus Elfring <Markus.Elfring@....de>,
    netfs@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
    linux-erofs@...ts.ozlabs.org, Jeff Layton <jlayton@...nel.org>,
    stable@...nel.org, LKML <linux-kernel@...r.kernel.org>,
    Christian Brauner <brauner@...nel.org>,
    Gao Xiang <hsiangkao@...ux.alibaba.com>,
    Hou Tao <houtao1@...wei.com>, Jingbo Xu <jefflexu@...ux.alibaba.com>,
    Yang Erkun <yangerkun@...wei.com>, Yu Kuai <yukuai3@...wei.com>,
    Zizhi Wo <wozizhi@...wei.com>, Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open_file()

Baokun Li <libaokun@...weicloud.com> wrote:

> Actually, at first I was going to release the reference count of the
> dentry uniformly in cachefiles_look_up_object() and delete all dput()
> in cachefiles_open_file(),

You couldn't do that anyway, since kernel_file_open() steals the caller's ref
if successful.

> but this may conflict when backporting the code to stable. So just keep it
> simple to facilitate backporting to stable.

Prioritise upstream, please.

I think Markus's suggestion of inserting a label and switching to a goto is
better.

Thanks,
David