linux-kernel - Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faa5f1d0-4300-42b3-a91f-e20fda87dfed@kernel.org>
Date: Wed, 28 Aug 2024 15:02:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacobe Zang <jacobe.zang@...ion.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 asahi@...ts.linux.dev
Subject: Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac"
 fallback compatible

On 28/08/2024 10:45, Jacobe Zang wrote:
> Wi-Fi compatible in these DTS is based on PCI ID. Bindings need
> "brcm,bcm4329-fmac" as fallback compatible.
> 
> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
> ---
>  arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +-
>  arch/arm64/boot/dts/apple/t8112-j413.dts  | 2 +-
>  arch/arm64/boot/dts/apple/t8112-j493.dts  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

Bindings are being questioned, so link to them in changelog section
would help the maintainers to decide when to apply it.

I am not convinced this is correct bindings change, thus this DTS should
wait.

Your previous patch also misses link to bindings. Whenever you split DTS
to separate series, please always provide link to the bindings, so
people will have the context.

Best regards,
Krzysztof