linux-kernel - Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE imx28 based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <737edb34-688d-4800-bb50-2374ac94ac75@kernel.org>
Date: Tue, 27 Aug 2024 11:00:35 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>
Cc: Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE
 imx28 based devices

On 27/08/2024 10:42, Lukasz Majewski wrote:
> The description for imx28 based devices needs to be updated after some
> further development.

Everything is an update, please be specific in commit subject and message.

> 
> Signed-off-by: Lukasz Majewski <lukma@...x.de>
> ---
>  arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi | 38 +++++++++---------------
>  1 file changed, 14 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> index 69fcb0dde940..6fa1f3e25b08 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> @@ -55,23 +55,6 @@ &i2c0 {
>  	status = "okay";
>  };
>  
> -&saif0 {
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&saif0_pins_a>;
> -	#sound-dai-cells = <0>;
> -	assigned-clocks = <&clks 53>;
> -	assigned-clock-rates = <12000000>;
> -	status = "okay";
> -};
> -
> -&saif1 {
> -	pinctrl-names = "default";
> -	pinctrl-0 = <&saif1_pins_a>;
> -	fsl,saif-master = <&saif0>;
> -	#sound-dai-cells = <0>;
> -	status = "okay";
> -};
> -
>  &spi3_pins_a {
>  	fsl,pinmux-ids = <
>  		MX28_PAD_AUART2_RX__SSP3_D4
> @@ -109,7 +92,7 @@ &ssp3 {
>  
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
> -		spi-max-frequency = <40000000>;
> +		spi-max-frequency = <20000000>;
>  		reg = <0>;
>  
>  		partitions {
> @@ -133,14 +116,21 @@ partition@...00 {
>  				reg = <0x90000 0x10000>;
>  			};
>  
> -			partition@...000 {
> -				label = "kernel";
> -				reg = <0x100000 0x400000>;
> +			partition@3 {

This does not look right. It is neither explained in commit msg, nor
matching reg.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

> +				label = "rescue";
> +				reg = <0xA0000 0xF40000>;

Lowercase hex

> +			};
> +

Best regards,
Krzysztof