linux-kernel - Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE imx28 based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827142608.36961a3d@wsk>
Date: Tue, 27 Aug 2024 14:26:08 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
 Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE
 imx28 based devices

Hi Krzysztof,

> On 27/08/2024 10:42, Lukasz Majewski wrote:
> > The description for imx28 based devices needs to be updated after
> > some further development.  
> 
> Everything is an update, please be specific in commit subject and
> message.

Ok.

> 
> > 
> > Signed-off-by: Lukasz Majewski <lukma@...x.de>
> > ---
> >  arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi | 38
> > +++++++++--------------- 1 file changed, 14 insertions(+), 24
> > deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> > b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi index
> > 69fcb0dde940..6fa1f3e25b08 100644 ---
> > a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi +++
> > b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi @@ -55,23 +55,6 @@ &i2c0
> > { status = "okay";
> >  };
> >  
> > -&saif0 {
> > -	pinctrl-names = "default";
> > -	pinctrl-0 = <&saif0_pins_a>;
> > -	#sound-dai-cells = <0>;
> > -	assigned-clocks = <&clks 53>;
> > -	assigned-clock-rates = <12000000>;
> > -	status = "okay";
> > -};
> > -
> > -&saif1 {
> > -	pinctrl-names = "default";
> > -	pinctrl-0 = <&saif1_pins_a>;
> > -	fsl,saif-master = <&saif0>;
> > -	#sound-dai-cells = <0>;
> > -	status = "okay";
> > -};
> > -
> >  &spi3_pins_a {
> >  	fsl,pinmux-ids = <
> >  		MX28_PAD_AUART2_RX__SSP3_D4
> > @@ -109,7 +92,7 @@ &ssp3 {
> >  
> >  	flash@0 {
> >  		compatible = "jedec,spi-nor";
> > -		spi-max-frequency = <40000000>;
> > +		spi-max-frequency = <20000000>;
> >  		reg = <0>;
> >  
> >  		partitions {
> > @@ -133,14 +116,21 @@ partition@...00 {
> >  				reg = <0x90000 0x10000>;
> >  			};
> >  
> > -			partition@...000 {
> > -				label = "kernel";
> > -				reg = <0x100000 0x400000>;
> > +			partition@3 {  
> 
> This does not look right. It is neither explained in commit msg, nor
> matching reg.

The SPI-NOR memory layout has evolved during time lifetime of the
device - for example special partitions to keep track of booted devices
for A/B booting scheme was added.

> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

Could you be more specific here?

For example:
CROSS_COMPILE="*-gcc" ARCH=arm make -j4 dtbs_check W=1

Show:
arch/arm/boot/dts/nxp/mxs/imx28-xea.dtb:
/apb@...00000/apbx@...40000/saif@...42000: failed to match any schema
with compatible: ['fsl,imx28-saif']

Where the 'saif' sound driver is already supported:
git grep -n "fsl,imx28-saif"
Documentation/devicetree/bindings/sound/mxs-saif.txt:27: compatible = "fsl,imx28-saif";
Documentation/devicetree/bindings/sound/mxs-saif.txt:35: compatible = "fsl,imx28-saif";
arch/arm/boot/dts/nxp/mxs/imx28.dtsi:1110: compatible = "fsl,imx28-saif";
arch/arm/boot/dts/nxp/mxs/imx28.dtsi:1127: compatible = "fsl,imx28-saif";

Changes from this patch do not touch the generic imx28.{dtsi} code at
all.

I would assume, that the portion of my patch shall not bring any new,
extra warnings/errors?

> 
> > +				label = "rescue";
> > +				reg = <0xA0000 0xF40000>;  
> 
> Lowercase hex

Ok.

> 
> > +			};
> > +  
> 
> Best regards,
> Krzysztof
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped