linux-kernel - Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE imx28 based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c032005-556d-4466-beff-9e9c3ca60aa1@kernel.org>
Date: Tue, 27 Aug 2024 14:38:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dts: nxp: mxs: Update device tree description for LWE
 imx28 based devices

On 27/08/2024 14:26, Lukasz Majewski wrote:
>>>  
>>> -			partition@...000 {
>>> -				label = "kernel";
>>> -				reg = <0x100000 0x400000>;
>>> +			partition@3 {  
>>
>> This does not look right. It is neither explained in commit msg, nor
>> matching reg.
> 
> The SPI-NOR memory layout has evolved during time lifetime of the
> device - for example special partitions to keep track of booted devices
> for A/B booting scheme was added.
> 
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
> 
> Could you be more specific here?

The @3 does not match "reg" as I wrote above. reg property and unit
address should match.

> 
> For example:
> CROSS_COMPILE="*-gcc" ARCH=arm make -j4 dtbs_check W=1
> 
> Show:
> arch/arm/boot/dts/nxp/mxs/imx28-xea.dtb:
> /apb@...00000/apbx@...40000/saif@...42000: failed to match any schema
> with compatible: ['fsl,imx28-saif']
> 
> Where the 'saif' sound driver is already supported:
> git grep -n "fsl,imx28-saif"
> Documentation/devicetree/bindings/sound/mxs-saif.txt:27: compatible = "fsl,imx28-saif";
> Documentation/devicetree/bindings/sound/mxs-saif.txt:35: compatible = "fsl,imx28-saif";
> arch/arm/boot/dts/nxp/mxs/imx28.dtsi:1110: compatible = "fsl,imx28-saif";
> arch/arm/boot/dts/nxp/mxs/imx28.dtsi:1127: compatible = "fsl,imx28-saif";
> 
> Changes from this patch do not touch the generic imx28.{dtsi} code at
> all.
> 
> I would assume, that the portion of my patch shall not bring any new,
> extra warnings/errors?

Heh, I would swear we have a warning for this... well, still this should
be fixed.


Best regards,
Krzysztof