linux-kernel - Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b6112b1-ce10-4e14-87d4-04d64972be56@linuxfoundation.org>
Date: Tue, 27 Aug 2024 05:38:17 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Dev Jain <dev.jain@....com>, shuah@...nel.org, oleg@...hat.com
Cc: mingo@...nel.org, tglx@...utronix.de, mark.rutland@....com,
 ryan.roberts@....com, broonie@...nel.org, suzuki.poulose@....com,
 Anshuman.Khandual@....com, DeepakKumar.Mishra@....com,
 aneesh.kumar@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal

On 8/22/24 05:10, Dev Jain wrote:
> 
> On 8/22/24 08:33, Shuah Khan wrote:
>> On 8/21/24 00:15, Dev Jain wrote:
>>> Rename sigaltstack to signal, and rename the existing test to
>>> sigaltstack.c.
>>
>> Can you elaborate on the benefits if renaming the test?
>>
>> Also you have such a good information in the cover-letter for this
>> patch - it would be good to include it in the change log for this
>> one or the new test.
> 
> Okay.
> 
> 
>>
>> The new test itself is good. I don't understand the value of renaming.
>> I can see the problems due to not being able to fix stables if the
>> existing test needs fixing. If there are good reasons for renaming,
>> I am all for it.
> 
> After looking into some git history, now I understand that "sas" actually
> has some meaning, although I still can't find its full-form :) I thought that
> sigaltstack would be a better name, but I guess sas is a subset of sigaltstack
> as part of SA_ONSTACK. So, let us drop the renaming of the test.
> 

I assume you will be sending a new v6 patch series without the renaming and just the
new test?

thanks,
-- Shuah