linux-kernel - Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828165954.4d2uf65khni7rlr5@uncurled>
Date: Wed, 28 Aug 2024 11:59:54 -0500
From: Nishanth Menon <nm@...com>
To: Robert Nelson <robertcnelson@...il.com>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Vignesh
 Raghavendra <vigneshr@...com>, Andrew Davis <afd@...com>,
        Jai Luthra
	<j-luthra@...com>, Roger Quadros <rogerq@...nel.org>,
        Siddharth Vadapalli
	<s-vadapalli@...com>,
        Jared McArthur <j-mcarthur@...com>,
        Jason Kridner
	<jkridner@...gleboard.org>,
        Deepak Khatri <lorforlinux@...gleboard.org>,
        Drew
 Fustini <drew@...gleboard.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai

On 11:34-20240828, Robert Nelson wrote:
[...]
> 
> /builds/RobertCNelson/arm64-multiplatform/KERNEL/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb:
> leds: led-0:linux,default-trigger: 'oneOf' conditional failed, one
> must be fixed:
> 'off' is not one of ['backlight', 'default-on', 'heartbeat',
> 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern',
> 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash',
> 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget',
> 'usb-host', 'usbport']
> 
> I guess, 'none' is close... off/etc..
> 

I'd just suggest to drop the property since you already use heartbeat.

Also function = is alternate option, if you choose to go down the road
of enabling a function

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/leds/common.h#n77

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml#n83


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D