linux-kernel - Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCHtYhdoaxERuB89orO=mn3vdt=_h1zvay+1Tr3Z0FEnes95A@mail.gmail.com>
Date: Wed, 28 Aug 2024 14:43:47 -0500
From: Robert Nelson <robertcnelson@...il.com>
To: Nishanth Menon <nm@...com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Vignesh Raghavendra <vigneshr@...com>, Andrew Davis <afd@...com>, Jai Luthra <j-luthra@...com>, 
	Roger Quadros <rogerq@...nel.org>, Siddharth Vadapalli <s-vadapalli@...com>, 
	Jared McArthur <j-mcarthur@...com>, Jason Kridner <jkridner@...gleboard.org>, 
	Deepak Khatri <lorforlinux@...gleboard.org>, Drew Fustini <drew@...gleboard.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai

On Wed, Aug 28, 2024 at 11:59 AM Nishanth Menon <nm@...com> wrote:
>
> On 11:34-20240828, Robert Nelson wrote:
> [...]
> >
> > /builds/RobertCNelson/arm64-multiplatform/KERNEL/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb:
> > leds: led-0:linux,default-trigger: 'oneOf' conditional failed, one
> > must be fixed:
> > 'off' is not one of ['backlight', 'default-on', 'heartbeat',
> > 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern',
> > 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash',
> > 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget',
> > 'usb-host', 'usbport']
> >
> > I guess, 'none' is close... off/etc..
> >
>
> I'd just suggest to drop the property since you already use heartbeat.
>
> Also function = is alternate option, if you choose to go down the road
> of enabling a function
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/leds/common.h#n77
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml#n83

I can drop it, we basically have two leds on the board... Red and
Green.. Jason didn't like the Red being activity as it looks like
something is wrong, we just turn it off once into Linux..  Thus Green
became heartbeat..

>From a user perspective (when they don't have a serial cable),
Blinking red = in u-boot board starting up... Blinking Green = in
Linux finishing bootup..

Regards,

-- 
Robert Nelson
https://rcn-ee.com/