linux-kernel - Re: [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the trace ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7eb981c3-4a5c-4173-a62a-7180acb9f299@web.de>
Date: Wed, 28 Aug 2024 19:50:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jie Gan <quic_jiegan@...cinc.com>, coresight@...ts.linaro.org,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 James Clark <james.clark@...aro.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Mike Leach <mike.leach@...aro.org>, Rob Herring <robh@...nel.org>,
 Suzuki Poulouse <suzuki.poulose@....com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jinlong Mao <quic_jinlmao@...cinc.com>, Song Chai
 <quic_songchai@...cinc.com>, Tingwei Zhang <quic_tingweiz@...cinc.com>,
 Tao Zhang <quic_taozha@...cinc.com>,
 Yuanfang Zhang <quic_yuanfang@...cinc.com>
Subject: Re: [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the
 trace ID

…
> +++ b/drivers/hwtracing/coresight/coresight-sysfs.c
> @@ -168,6 +168,7 @@ int coresight_enable_sysfs(struct coresight_device *csdev)
>  	int cpu, ret = 0;
>  	struct coresight_device *sink;
>  	struct list_head *path;
> +	struct cs_sink_data *sink_data;
…

* How do you think about to use the attribute “__free(kfree)” at more places accordingly?
  https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/slab.h#L282

* Would you like to reduce the scope for such a local variable?


Regards,
Markus