linux-kernel - Re: [PATCH v4 4/5] Coresight: Add Coresight TMC Control Unit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95cea320-4c47-4399-a615-295fc1129c04@web.de>
Date: Wed, 28 Aug 2024 19:52:09 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jie Gan <quic_jiegan@...cinc.com>, coresight@...ts.linaro.org,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 James Clark <james.clark@...aro.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Mike Leach <mike.leach@...aro.org>, Rob Herring <robh@...nel.org>,
 Suzuki Poulouse <suzuki.poulose@....com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jinlong Mao <quic_jinlmao@...cinc.com>, Song Chai
 <quic_songchai@...cinc.com>, Tingwei Zhang <quic_tingweiz@...cinc.com>,
 Tao Zhang <quic_taozha@...cinc.com>,
 Yuanfang Zhang <quic_yuanfang@...cinc.com>
Subject: Re: [PATCH v4 4/5] Coresight: Add Coresight TMC Control Unit driver

…
> +++ b/drivers/hwtracing/coresight/coresight-ctcu.c
> @@ -0,0 +1,292 @@
…
> +static int __ctcu_set_etr_traceid(struct coresight_device *csdev,
> +				  u8 traceid,
> +				  int port_num,
> +				  bool enable)
> +{
…
> +	spin_lock_irqsave(&drvdata->spin_lock, flags);
> +	CS_UNLOCK(drvdata->base);
…
> +	CS_LOCK(drvdata->base);
> +	spin_unlock_irqrestore(&drvdata->spin_lock, flags);
> +
> +	return 0;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&drvdata->spin_lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L572

Regards,
Markus