linux-kernel - Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efe13a61-1607-419d-b330-9a7061511719@gmail.com>
Date: Wed, 28 Aug 2024 20:53:38 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Nilo Alexandre <n1lux.comp@...il.com>, gregkh@...uxfoundation.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 ~lkcamp/patches@...ts.sr.ht
Subject: Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in
 r8192E_dev.c 325

On 8/28/24 03:18, Nilo Alexandre wrote:
> Remove linebreak to improve readability
> 
Hi Nilo,

please end the above sentences with a ".".


> CHECK: Alignment should match open parenthesis
Why do we need the above line?

Thanks for your support.

Bye Philipp
> 
> Signed-off-by: Nilo Alexandre <n1lux.comp@...il.com>
> ---
> v4: Remove linebreak to improve readability
> v3: Fix typo in commit message.
> v2: Using tabs instead of spaces.
> ---
>   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b25e83743956d..a80efe6c7c209 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>   
>   		if (priv->epromtype == EEPROM_93C46) {
>   			if (!priv->autoload_fail_flag) {
> -				usValue = rtl92e_eeprom_read(dev,
> -					  EEPROM_TxPwDiff_CrystalCap >> 1);
> +				usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
>   				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
>   				priv->eeprom_crystal_cap = (usValue & 0xf000)
>   							 >> 12;