linux-kernel - Re: [PATCH] clk: bcm: bcm53573: fix OF node leak in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29cda960bebe1c034d53ace2f57731c2.sboyd@kernel.org>
Date: Wed, 28 Aug 2024 11:54:25 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Michael Turquette <mturquette@...libre.com>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH] clk: bcm: bcm53573: fix OF node leak in init

Quoting Krzysztof Kozlowski (2024-08-25 23:58:01)
> Driver code is leaking OF node reference from of_get_parent() in
> bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
> first place, because the parent node will not be freed while we are
> processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
> leak by accessing parent directly, instead of of_get_parent().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Applied to clk-next