linux-kernel - Re: [PATCH v10 3/4] firmware: ti_sci: Introduce Power Management Ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56kmiba5cr7re6rdzak5g72pprwfgvme5v4tq6rovrxrd6kefe@5mx5xxdfs7dp>
Date: Wed, 28 Aug 2024 21:54:19 +0200
From: Markus Schneider-Pargmann <msp@...libre.com>
To: Nishanth Menon <nm@...com>
Cc: Kevin Hilman <khilman@...libre.com>, Tero Kristo <kristo@...nel.org>, 
	Santosh Shilimkar <ssantosh@...nel.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, Vibhore Vardhan <vibhore@...com>, Dhruva Gole <d-gole@...com>, 
	Akashdeep Kaur <a-kaur@...com>
Subject: Re: [PATCH v10 3/4] firmware: ti_sci: Introduce Power Management Ops

Hi Nishanth,

thanks for your review. I will integrate fixes for all your comments
into the next version.

On Mon, Aug 26, 2024 at 11:43:46AM GMT, Nishanth Menon wrote:
> On 08:39-20240814, Kevin Hilman wrote:
> [...]
> > diff --git a/include/linux/soc/ti/ti_sci_protocol.h b/include/linux/soc/ti/ti_sci_protocol.h
> > index 1f1871e23f76..4ba9e520a28f 100644
> > --- a/include/linux/soc/ti/ti_sci_protocol.h
> > +++ b/include/linux/soc/ti/ti_sci_protocol.h
> > @@ -199,6 +199,47 @@ struct ti_sci_clk_ops {
> >  #define TISCI_MSG_VALUE_IO_ENABLE			1
> >  #define TISCI_MSG_VALUE_IO_DISABLE			0
> >  
> > +/* TISCI LPM wake up sources */
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_I2C0	0x00
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_UART0	0x10
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_MCU_GPIO0	0x20
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_ICEMELTER0	0x30
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_TIMER0	0x40
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_TIMER1	0x41
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_WKUP_RTC0	0x50
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_RESET		0x60
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_USB0		0x70
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_USB1		0x71
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_MAIN_IO		0x80
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_MCU_IO		0x81
> 
> ^^ I assume these are daisy chain sources. - will these remain OR do we
> have to consider the wake sources SoC dependent? If so, the
> sci_protocol.h will be SoC agnostic..

These are all wakeup sources from LPM for the AM62 family of SoCs, not
only daisy chain sources. The currently defined wakeup sources are
relevant for am62x/a/p but will also be reused for others where
possible. Otherwise these can be extended in the future for other wakeup
sources.

Best
Markus

> 
> 
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_CAN_IO		0x82
> > +#define TISCI_MSG_VALUE_LPM_WAKE_SOURCE_INVALID		0xFF
> > +
> > +/* TISCI LPM constraint state values */
> > +#define TISCI_MSG_CONSTRAINT_SET			1
> > +#define TISCI_MSG_CONSTRAINT_CLR			0
> > +
> 
> [...]
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D