linux-kernel - Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cbf98cf-9b1a-455e-afcd-b0cdfcf1aaec@gmail.com>
Date: Wed, 28 Aug 2024 22:25:56 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: vivek t s <vivek6429.ts@...il.com>, gregkh@...uxfoundation.org
Cc: dan.carpenter@...aro.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

On 8/28/24 14:21, vivek t s wrote:
> Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> warning from checkpatch.
> 
> Signed-off-by: vivek t s<vivek6429.ts@...il.com>

Hi Vivek,

the description can be improved. Please always consider that checkpatch 
can be wrong. So checkpatch is not a justification.

I propose (feel free to improve):
Rename function SelectChannel() to r8723bs_select_channel() to avoid
CamelCase and to improve cleanliness of the global namespace.

Thanks for your support.

Bye Philipp