linux-kernel - Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZtHcrs3GoRZJiLjS@victor-IdeaPad-Gaming-3-16IAH7>
Date: Fri, 30 Aug 2024 20:22:30 +0530
From: YOUR NAME <vivek6429.ts@...il.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc: gregkh@...uxfoundation.org, dan.carpenter@...aro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

On Wed, Aug 28, 2024 at 10:25:56PM +0200, Philipp Hortmann wrote:
> On 8/28/24 14:21, vivek t s wrote:
> > Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> > warning from checkpatch.
> > 
> > Signed-off-by: vivek t s<vivek6429.ts@...il.com>
> 
> Hi Vivek,
> 
> the description can be improved. Please always consider that checkpatch can
> be wrong. So checkpatch is not a justification.
> 
> I propose (feel free to improve):
> Rename function SelectChannel() to r8723bs_select_channel() to avoid
> CamelCase and to improve cleanliness of the global namespace.
> 
> Thanks for your support.
> 
> Bye Philipp

okay, understood.
i shall change the description and send again.

thanks,
vivek