linux-kernel - Re: [PATCH 1/4] perf report: Fix segfault when 'sym' sort key is not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zs-VP5uWCeIdooB_@x1>
Date: Wed, 28 Aug 2024 18:23:11 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org,
	Stephane Eranian <eranian@...gle.com>,
	Matt Fleming <matt@...dmodwrite.com>
Subject: Re: [PATCH 1/4] perf report: Fix segfault when 'sym' sort key is not
 used

On Mon, Aug 26, 2024 at 03:10:42PM -0700, Namhyung Kim wrote:
> The fields in the hist_entry are filled on-demand which means they only
> have meaningful values when relevant sort keys are used.  So if neither
> of 'dso' nor 'sym' sort keys are used, the map/symbols in the hist entry
> can be garbage.  So it shouldn't access it unconditionally.
> 
> I got a segfault, when I wanted to see cgroup profiles.

Thanks, applied the series to perf-tools-next,

- Arnaldo