linux-kernel - Re: [PATCH] clk: analogbits: Fix incorrect calculation of vco rate delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b245182-09db-44a1-bdee-3ec0658bef47@gmail.com>
Date: Wed, 28 Aug 2024 14:23:37 -0700
From: Bo Gan <ganboing@...il.com>
To: Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: samuel.holland@...ive.com, emil.renner.berthing@...onical.com,
 mturquette@...libre.com, paul.walmsley@...ive.com
Subject: Re: [PATCH] clk: analogbits: Fix incorrect calculation of vco rate
 delta

On 8/28/24 11:52, Stephen Boyd wrote:
> Quoting Bo Gan (2024-08-26 23:19:54)
>> In function `wrpll_configure_for_rate`, we try to determine the best PLL
>> configuration for a target rate. However, in the loop where we try values
>> of R, we should compare the derived `vco` with `target_vco_rate`. However,
>> we were in fact comparing it with `target_rate`, which is actually after
>> Q shift. This is incorrect, and sometimes can result in suboptimal clock
>> rates. This patch fixes it.
>>
>> Signed-off-by: Bo Gan <ganboing@...il.com>
>> ---
> 
> Please add a Fixes tag.
> 
> Also, your patch has tons of diff context. Why?

Hi Stephen,

Thanks for the reply. I'll add the Fixes tag in v2. I explicitly enlarged the
diff to show more surrounding contexts for better readability. Any other issue
I should fix?

Bo