linux-kernel - Re: [PATCH] LoongArch: Remove posix_types.h include from sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8cc0f2d1e82097ab8646edfdd2a4a1fca386bcc.camel@xry111.site>
Date: Wed, 28 Aug 2024 12:27:20 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Remove posix_types.h include from
 sigcontext.h

On Wed, 2024-08-28 at 12:11 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
> 
> Just some questions:
> 1, Changing UAPI is not a good idea.

But removing unneeded includes from UAPI is fine.  For example, the
commit 44e0b165b6c078b84767da4ba06ffa27af562c96 has removed
linux/posix_types.h from termbits.h for all ports.

> 2. In another thread you said that "paper over" is not enough for some
> cases.
> 3. include/uapi/linux/types.h still include linux/posix_types.h, why
> your "paper over" works?

Well maybe it does not work (I've not seriously tested as it's just a
paper over).  But removing unneeded include is correct on its own
anyway.  And ...

> > The unneeded include was found debugging some vDSO self test build
> > failure (it's not the root cause though).

So it's just "found" debugging the issue.  Maybe I should change "it's
not the root cause" to "it's not really related to that issue"?
> 

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University