linux-kernel - Re: [PATCH] LoongArch: Remove posix_types.h include from sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H5dDkyd5qkipwbKJvNduWM0UgENBqMHJGXhEoekizneaw@mail.gmail.com>
Date: Wed, 28 Aug 2024 12:11:21 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Xi Ruoyao <xry111@...111.site>
Cc: WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Remove posix_types.h include from sigcontext.h

Hi, Ruoyao,

Just some questions:
1, Changing UAPI is not a good idea.
2. In another thread you said that "paper over" is not enough for some cases.
3. include/uapi/linux/types.h still include linux/posix_types.h, why
your "paper over" works?

Huacai

On Wed, Aug 28, 2024 at 11:14 AM Xi Ruoyao <xry111@...111.site> wrote:
>
> Nothing in sigcontext.h seems to require anything from
> linux/posix_types.h.  This include seems a MIPS relic originated from
> an error in Linux 2.6.11-rc2 (in 2005).
>
> The unneeded include was found debugging some vDSO self test build
> failure (it's not the root cause though).
>
> Link: https://lore.kernel.org/linux-mips/20240828030413.143930-2-xry111@xry111.site/
> Link: https://lore.kernel.org/loongarch/0b540679ec8cfccec75aeb3463810924f6ff71e6.camel@xry111.site/
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/loongarch/include/uapi/asm/sigcontext.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/loongarch/include/uapi/asm/sigcontext.h b/arch/loongarch/include/uapi/asm/sigcontext.h
> index 6c22f616b8f1..5cd121275bac 100644
> --- a/arch/loongarch/include/uapi/asm/sigcontext.h
> +++ b/arch/loongarch/include/uapi/asm/sigcontext.h
> @@ -9,7 +9,6 @@
>  #define _UAPI_ASM_SIGCONTEXT_H
>
>  #include <linux/types.h>
> -#include <linux/posix_types.h>
>
>  /* FP context was used */
>  #define SC_USED_FP             (1 << 0)
> --
> 2.46.0
>