| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202408281442.Xos98wkO-lkp@intel.com>
Date: Wed, 28 Aug 2024 15:16:03 +0800
From: kernel test robot <lkp@...el.com>
To: David Leonard <David.Leonard@...i.com>,
linux-arm-kernel@...ts.infradead.org
Cc: oe-kbuild-all@...ts.linux.dev, Dong Aisheng <aisheng.dong@....com>,
Fabio Estevam <festevam@...il.com>, Shawn Guo <shawnguo@...nel.org>,
Jacky Bai <ping.bai@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Linus Walleij <linus.walleij@...aro.org>,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 4/6] pinctrl: ls1046a: Add pinctrl driver support
Hi David,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next shawnguo/for-next arm64/for-next/core kvmarm/next rockchip/for-next soc/for-next linus/master v6.11-rc5 next-20240827]
[cannot apply to arm/for-next arm/fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/David-Leonard/arm64-dts-ls1012a-add-pinctrl-node/20240827-104431
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/c0ecf4f4-94f1-2efd-b05b-fc117c62e516%40digi.com
patch subject: [PATCH 4/6] pinctrl: ls1046a: Add pinctrl driver support
config: sh-randconfig-r113-20240828 (https://download.01.org/0day-ci/archive/20240828/202408281442.Xos98wkO-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce: (https://download.01.org/0day-ci/archive/20240828/202408281442.Xos98wkO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408281442.Xos98wkO-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/pinctrl/freescale/pinctrl-ls1046a.c:55:31: sparse: sparse: symbol 'ls1046a_pins' was not declared. Should it be static?
>> drivers/pinctrl/freescale/pinctrl-ls1046a.c:199:59: sparse: sparse: incorrect type in argument 2 (different modifiers) @@ expected struct pinctrl_desc *pctldesc @@ got struct pinctrl_desc const * @@
drivers/pinctrl/freescale/pinctrl-ls1046a.c:199:59: sparse: expected struct pinctrl_desc *pctldesc
drivers/pinctrl/freescale/pinctrl-ls1046a.c:199:59: sparse: got struct pinctrl_desc const *
vim +/ls1046a_pins +55 drivers/pinctrl/freescale/pinctrl-ls1046a.c
54
> 55 const struct pinctrl_pin_desc ls1046a_pins[] = {
56 PINCTRL_PIN(PIN_L4, "L4"),
57 PINCTRL_PIN(PIN_M4, "M4"),
58 PINCTRL_PIN(PIN_M3, "M3"),
59 PINCTRL_PIN(PIN_N3, "N3"),
60 };
61
62 /* Each pin is its own group */
63 static const char * const ls1046a_groups[] = { "L4", "M4", "M3", "N3" };
64
65 static int ls1046a_get_groups_count(struct pinctrl_dev *pcdev)
66 {
67 return ARRAY_SIZE(ls1046a_pins);
68 }
69
70 static const char *ls1046a_get_group_name(struct pinctrl_dev *pcdev,
71 unsigned int selector)
72 {
73 return ls1046a_pins[selector].name;
74 }
75
76 static int ls1046a_get_group_pins(struct pinctrl_dev *pcdev,
77 unsigned int selector, const unsigned int **pins, unsigned int *npins)
78 {
79 *pins = &ls1046a_pins[selector].number;
80 *npins = 1;
81 return 0;
82 }
83
84 static const struct pinctrl_ops ls1046a_pinctrl_ops = {
85 .get_groups_count = ls1046a_get_groups_count,
86 .get_group_name = ls1046a_get_group_name,
87 .get_group_pins = ls1046a_get_group_pins,
88 .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
89 .dt_free_map = pinconf_generic_dt_free_map,
90 };
91
92 /* Every pin has the same set of functions */
93 #define FUNC_i2c 0
94 #define FUNC_gpio 1
95 #define FUNC_evt 2
96 #define FUNC_usb 3
97 #define FUNC_ftm 4
98
99 #define _PINFUNC(name) \
100 [FUNC_##name] = PINCTRL_PINFUNCTION(#name, ls1046a_groups, ARRAY_SIZE(ls1046a_groups))
101 static const struct pinfunction ls1046a_functions[] = {
102 _PINFUNC(i2c),
103 _PINFUNC(gpio),
104 _PINFUNC(evt),
105 _PINFUNC(usb),
106 _PINFUNC(ftm),
107 };
108
109 static int ls1046a_get_functions_count(struct pinctrl_dev *pctldev)
110 {
111 return ARRAY_SIZE(ls1046a_functions);
112 }
113
114 static const char *ls1046a_get_function_name(struct pinctrl_dev *pctldev, unsigned int func)
115 {
116 return ls1046a_functions[func].name;
117 }
118
119 static int ls1046a_get_function_groups(struct pinctrl_dev *pctldev, unsigned int func,
120 const char * const **groups,
121 unsigned int * const ngroups)
122 {
123 *groups = ls1046a_functions[func].groups;
124 *ngroups = ls1046a_functions[func].ngroups;
125 return 0;
126 }
127
128 static int ls1046a_set_mux(struct pinctrl_dev *pcdev,
129 unsigned int func, unsigned int pin)
130 {
131 struct ls1046a_pinctrl_pdata *pd = pinctrl_dev_get_drvdata(pcdev);
132 static const u32 cr0_reg_func[] = {
133 [FUNC_i2c] = RCWPMUXCR0_FUNC_I2C,
134 [FUNC_gpio] = RCWPMUXCR0_FUNC_GPIO,
135 [FUNC_evt] = RCWPMUXCR0_FUNC_EVT,
136 [FUNC_usb] = RCWPMUXCR0_FUNC_USB,
137 [FUNC_ftm] = RCWPMUXCR0_FUNC_FTM,
138 };
139 static const unsigned int cr0_pin_shift[] = {
140 [PIN_L4] = RCWPMUXCR0_IIC3_SCL_SHIFT,
141 [PIN_M4] = RCWPMUXCR0_IIC3_SDA_SHIFT,
142 [PIN_M3] = RCWPMUXCR0_IIC4_SCL_SHIFT,
143 [PIN_N3] = RCWPMUXCR0_IIC4_SDA_SHIFT,
144 };
145 u32 cr0;
146
147 if (pd->big_endian)
148 cr0 = ioread32be(pd->cr0mem);
149 else
150 cr0 = ioread32(pd->cr0mem);
151
152 unsigned int pin_shift = cr0_pin_shift[pin];
153 u32 reg_func = cr0_reg_func[func];
154 u32 newcr0 = (cr0 & ~RCWPMUXCR0_MASK(pin_shift)) |
155 RCWPMUXCR0_FIELD(pin_shift, reg_func);
156
157 if (pd->big_endian)
158 iowrite32be(newcr0, pd->cr0mem);
159 else
160 iowrite32(newcr0, pd->cr0mem);
161 return 0;
162 }
163
164 static const struct pinmux_ops ls1046a_pinmux_ops = {
165 .get_functions_count = ls1046a_get_functions_count,
166 .get_function_name = ls1046a_get_function_name,
167 .get_function_groups = ls1046a_get_function_groups,
168 .set_mux = ls1046a_set_mux,
169 };
170
171 static const struct pinctrl_desc ls1046a_pinctrl_desc = {
172 .name = "ls1046a",
173 .pins = ls1046a_pins,
174 .npins = ARRAY_SIZE(ls1046a_pins),
175 .pctlops = &ls1046a_pinctrl_ops,
176 .pmxops = &ls1046a_pinmux_ops,
177 .owner = THIS_MODULE,
178 };
179
180 static int ls1046a_pinctrl_probe(struct platform_device *pdev)
181 {
182 struct ls1046a_pinctrl_pdata *pd;
183 int ret;
184
185 pd = devm_kzalloc(&pdev->dev, sizeof(*pd), GFP_KERNEL);
186 if (!pd)
187 return -ENOMEM;
188 platform_set_drvdata(pdev, pd);
189
190 pd->big_endian = device_is_big_endian(&pdev->dev);
191
192 /* SCFG PMUX0 */
193 pd->cr0mem = devm_platform_ioremap_resource(pdev, 0);
194 if (IS_ERR(pd->cr0mem))
195 return PTR_ERR(pd->cr0mem);
196 dev_dbg(&pdev->dev, "scfg pmuxcr0 at %px %s", pd->cr0mem,
197 pd->big_endian ? "be" : "le");
198
> 199 ret = devm_pinctrl_register_and_init(&pdev->dev, &ls1046a_pinctrl_desc,
200 pd, &pd->pctl_dev);
201 if (ret)
202 return dev_err_probe(&pdev->dev, ret, "Failed pinctrl init\n");
203
204 pinctrl_enable(pd->pctl_dev);
205 return ret;
206 }
207
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists