linux-kernel - Re: [PATCH 4/6] pinctrl: ls1046a: Add pinctrl driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaiSX6zbyqUqKPwApS-zQ8KYMCqHs0F7Sx17jGN1bpJoQ@mail.gmail.com>
Date: Sat, 31 Aug 2024 00:26:47 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: David Leonard <David.Leonard@...i.com>, linux-arm-kernel@...ts.infradead.org, 
	Dong Aisheng <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>, 
	Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 4/6] pinctrl: ls1046a: Add pinctrl driver support

On Tue, Aug 27, 2024 at 9:20 PM Frank Li <Frank.li@....com> wrote:
> On Tue, Aug 27, 2024 at 12:12:24PM +1000, David Leonard wrote:
> >
> > Add QorIQ LS1046A pinctrl driver allowing i2c-core to exert
> > GPIO control over the third and fourth I2C buses.
> >
> > Signed-off-by: David Leonard <David.Leonard@...i.com>
> > ---
>
> Why not use pinctrl-single,  please ref fsl,lx2160x.dtsi for GPIO/i2c
> recover.

I'm not so sure about that. Since the 1012 need to use a unique
driver this will be confusing across the family: one chip has
registers and values defined in the device tree, another has
them in the driver, if possible I would advice to keep this
consistent across sibling SoCs.

I can't stop anyone from using pinctrl-single but it's a bit
seductive in it's simplicity, while not always so user-friendly
with all the magic that ends up in the device trees.

Yours,
Linus Walleij