linux-kernel - Re: [PATCH] ASoC: dt-bindings: Add dt bindings definition file for imx28 saif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc53a03d-af82-4083-9dc0-82a8190cc382@kernel.org>
Date: Wed, 28 Aug 2024 10:11:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Fabio Estevam <festevam@...il.com>, Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: Add dt bindings definition file for
 imx28 saif

On 28/08/2024 10:01, Lukasz Majewski wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: fsl,imx28-saif
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#sound-dai-cells":
>>> +    const: 0
>>> +
>>> +  assigned-clock-parents: true
>>> +  assigned-clock-rates: true
>>> +  assigned-clocks: true  
>>
>> These three should be dropped, redundant.
> 
> Last two are present in definition of saif[01] in imx28.dtsi - so IMHO
> it shall be added.

But they are already accepted. Why they need to be mentioned twice?

> 
> Moreover, those are present in fsl,sg5000.yaml dt-schema description.
> 

There is no such file.

>>
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    saif0: saif@...42000 {
>>> +        #sound-dai-cells = <0>;
>>> +        compatible = "fsl,imx28-saif";
>>> +        reg = <0x80042000 2000>;
>>> +        interrupts = <59>;
>>> +        clocks = <&clks 53>;
>>> +        dmas = <&dma_apbx 4>;
>>> +        dma-names = "rx-tx";
>>> +    };
>>> +  - |
>>> +    saif1: saif@...46000 {  
>>
>> Just one example, could be this one as more complete.
> 
> This is important, as saif1 has "fsl,saif-master" which allows to have
> full duplex PCM communication (by default on imx28 single saif is
> half-duplex).
> 
So keep saif1.

Best regards,
Krzysztof