linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8186: Fix supported-hw mask for GPU OPPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66432301-d5ad-4703-a08d-833573e733e0@gmail.com>
Date: Wed, 28 Aug 2024 11:11:46 +0300
From: Alper Nebi Yasak <alpernebiyasak@...il.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wenst@...omium.org>,
 Matthias Brugger <matthias.bgg@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH] arm64: dts: mediatek: mt8186: Fix supported-hw mask for
 GPU OPPs

Hi,

On 2024-07-25 10:22 +03:00, AngeloGioacchino Del Regno wrote:
> The speedbin eFuse reads a value 'x' from 0 to 7 and, in order to
> make that compatible with opp-supported-hw, it gets post processed
> as BIT(x).
> 
> Change all of the 0x30 supported-hw to 0x20 to avoid getting
> duplicate OPPs for speedbin 4, and also change all of the 0x8 to
> 0xcf because speedbins different from 4 and 5 do support 900MHz,
> 950MHz, 1000MHz with the higher voltage of 850mV, 900mV, 950mV
> respectively.
> 
> Fixes: f38ea593ad0d ("arm64: dts: mediatek: mt8186: Wire up GPU voltage/frequency scaling")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---

Tested-by: Alper Nebi Yasak <alpernebiyasak@...il.com>

Appears to work on my magneton, I can see "Mali-G52 r1 (Panfrost)" as
the OpenGL renderer in various programs after this patch.

>  arch/arm64/boot/dts/mediatek/mt8186.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> index 4763ed5dc86c..d63a9defe73e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi
> @@ -731,7 +731,7 @@ opp-850000000 {
>  		opp-900000000-3 {
>  			opp-hz = /bits/ 64 <900000000>;
>  			opp-microvolt = <850000>;
> -			opp-supported-hw = <0x8>;
> +			opp-supported-hw = <0xcf>;
>  		};
>  
>  		opp-900000000-4 {
> @@ -743,13 +743,13 @@ opp-900000000-4 {
>  		opp-900000000-5 {
>  			opp-hz = /bits/ 64 <900000000>;
>  			opp-microvolt = <825000>;
> -			opp-supported-hw = <0x30>;
> +			opp-supported-hw = <0x20>;
>  		};
>  
>  		opp-950000000-3 {
>  			opp-hz = /bits/ 64 <950000000>;
>  			opp-microvolt = <900000>;
> -			opp-supported-hw = <0x8>;
> +			opp-supported-hw = <0xcf>;
>  		};
>  
>  		opp-950000000-4 {
> @@ -761,13 +761,13 @@ opp-950000000-4 {
>  		opp-950000000-5 {
>  			opp-hz = /bits/ 64 <950000000>;
>  			opp-microvolt = <850000>;
> -			opp-supported-hw = <0x30>;
> +			opp-supported-hw = <0x20>;
>  		};
>  
>  		opp-1000000000-3 {
>  			opp-hz = /bits/ 64 <1000000000>;
>  			opp-microvolt = <950000>;
> -			opp-supported-hw = <0x8>;
> +			opp-supported-hw = <0xcf>;
>  		};
>  
>  		opp-1000000000-4 {
> @@ -779,7 +779,7 @@ opp-1000000000-4 {
>  		opp-1000000000-5 {
>  			opp-hz = /bits/ 64 <1000000000>;
>  			opp-microvolt = <875000>;
> -			opp-supported-hw = <0x30>;
> +			opp-supported-hw = <0x20>;
>  		};
>  	};
>