linux-kernel - Re: [PATCH] tools/hv: Add memory allocation check in hv_fcopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d95656fd-cd64-4386-a22f-689a70d8327c@gmail.com>
Date: Wed, 28 Aug 2024 15:48:50 +0530
From: Praveen Kumar <kpraveen.lkml@...il.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, kys@...rosoft.com
Cc: haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
 linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/hv: Add memory allocation check in hv_fcopy_start

On 28/08/24 15:30, Zhu Jun wrote:
> Added checks for `file_name` and `path_name` memory allocation failures,
> with error logging and process exit on failure.
> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>   tools/hv/hv_fcopy_uio_daemon.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/hv/hv_fcopy_uio_daemon.c b/tools/hv/hv_fcopy_uio_daemon.c
> index 3ce316cc9f97..2efdf8d28e9c 100644
> --- a/tools/hv/hv_fcopy_uio_daemon.c
> +++ b/tools/hv/hv_fcopy_uio_daemon.c
> @@ -295,6 +295,10 @@ static int hv_fcopy_start(struct hv_start_fcopy *smsg_in)
>   
>   	file_name = (char *)malloc(file_size * sizeof(char));
>   	path_name = (char *)malloc(path_size * sizeof(char));
> +	if (!file_name || !path_name) {
> +		syslog(LOG_ERR, "Can't allocate memory!");

Probably, you may want to cleanup memory here in case either of one is 
successful allocation.

> +		exit(EXIT_FAILURE);
> +	}
>   
>   	wcstoutf8(file_name, (__u16 *)in_file_name, file_size);
>   	wcstoutf8(path_name, (__u16 *)in_path_name, path_size);