linux-kernel - Re: [PATCH net-next 3/6] net: ethernet: fs_enet: drop the .adjust_link custom fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdea1768-b44c-4bf5-931b-10f9357ed4cb@csgroup.eu>
Date: Wed, 28 Aug 2024 12:18:51 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net,
 Pantelis Antoniou <pantelis.antoniou@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, Florian Fainelli
 <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Herve Codina <herve.codina@...tlin.com>,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next 3/6] net: ethernet: fs_enet: drop the
 .adjust_link custom fs_ops



Le 28/08/2024 à 11:50, Maxime Chevallier a écrit :
> There's no in-tree user for the fs_ops .adjust_link() function, so we
> can always use the generic one in fe_enet-main.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 7 +------
>   drivers/net/ethernet/freescale/fs_enet/fs_enet.h      | 1 -
>   2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index 2b48a2a5e32d..caca81b3ccb6 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -649,12 +649,7 @@ static void fs_adjust_link(struct net_device *dev)
>   	unsigned long flags;
>   
>   	spin_lock_irqsave(&fep->lock, flags);
> -
> -	if (fep->ops->adjust_link)
> -		fep->ops->adjust_link(dev);
> -	else
> -		generic_adjust_link(dev);
> -
> +	generic_adjust_link(dev);
>   	spin_unlock_irqrestore(&fep->lock, flags);
>   }
>   
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index 21c07ac05225..abe4dc97e52a 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -77,7 +77,6 @@ struct fs_ops {
>   	void (*free_bd)(struct net_device *dev);
>   	void (*cleanup_data)(struct net_device *dev);
>   	void (*set_multicast_list)(struct net_device *dev);
> -	void (*adjust_link)(struct net_device *dev);
>   	void (*restart)(struct net_device *dev);
>   	void (*stop)(struct net_device *dev);
>   	void (*napi_clear_event)(struct net_device *dev);