linux-kernel - Re: [PATCH net-next 4/6] net: ethernet: fs_enet: drop unused phy_info and mii_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbe686fb-9bcf-4f25-ab26-a5330d10ad99@csgroup.eu>
Date: Wed, 28 Aug 2024 12:25:45 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net,
 Pantelis Antoniou <pantelis.antoniou@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, Florian Fainelli
 <f.fainelli@...il.com>, Heiner Kallweit <hkallweit1@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 thomas.petazzoni@...tlin.com, Herve Codina <herve.codina@...tlin.com>,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next 4/6] net: ethernet: fs_enet: drop unused phy_info
 and mii_if_info



Le 28/08/2024 à 11:51, Maxime Chevallier a écrit :
> There's no user of the struct phy_info, the 'phy' field and the
> mii_if_info in the fs_enet driver, probably dating back when phylib
> wasn't as widely used.  Drop these from the driver code.

Seems like they haven't been used since commit 5b4b8454344a ("[PATCH] 
FS_ENET: use PAL for mii management")

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> ---
>   drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index abe4dc97e52a..781f506c933c 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -92,14 +92,6 @@ struct fs_ops {
>   	void (*tx_restart)(struct net_device *dev);
>   };
>   
> -struct phy_info {
> -	unsigned int id;
> -	const char *name;
> -	void (*startup) (struct net_device * dev);
> -	void (*shutdown) (struct net_device * dev);
> -	void (*ack_int) (struct net_device * dev);
> -};
> -
>   /* The FEC stores dest/src/type, data, and checksum for receive packets.
>    */
>   #define MAX_MTU 1508		/* Allow fullsized pppoe packets over VLAN */
> @@ -153,10 +145,7 @@ struct fs_enet_private {
>   	cbd_t __iomem *cur_rx;
>   	cbd_t __iomem *cur_tx;
>   	int tx_free;
> -	const struct phy_info *phy;
>   	u32 msg_enable;
> -	struct mii_if_info mii_if;
> -	unsigned int last_mii_status;
>   	int interrupt;
>   
>   	int oldduplex, oldspeed, oldlink;	/* current settings */