linux-kernel - Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2092a3f1-e319-45c5-a33c-3f271e70785f@stanley.mountain>
Date: Wed, 28 Aug 2024 13:25:10 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: vivek t s <vivek6429.ts@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()

On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote:
> Rename SelectChannel() to select_channel() to avoid
> CamelCase warning from checkpatch.

I wouldn't have commented on this except there are some other issues.
Line wrap your commit message at 72-75 characters (similar to email).
So "CamelCase warning" moves to the line before.

Rename SelectChannel() to select_channel() to avoid CamelCase warning
from checkpatch.

> 
> compile tested.
> 

Put this under the --- cut off.  (This is the real reason why I'm responding to
your patch)

> Signed-off-by: vivek t s <vivek6429.ts@...il.com>

Your signed-off-by is like signing a legal document.  If you were buying a
house, then would you write your name like this?  If so then that's fine.

> ---
  ^^^
Cut off line here.

regards,
dan carpenter

>  drivers/staging/rtl8723bs/core/rtw_ap.c          | 4 ++--
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 4 ++--
>  drivers/staging/rtl8723bs/core/rtw_wlan_util.c   | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)