[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zs71hc9-p0vST-7Y@victor-IdeaPad-Gaming-3-16IAH7>
Date: Wed, 28 Aug 2024 15:31:41 +0530
From: YOUR NAME <vivek6429.ts@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Rename function SelectChannel()
On Wed, Aug 28, 2024 at 11:38:18AM +0200, Greg KH wrote:
> On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote:
> > --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> > +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
> > @@ -455,7 +455,7 @@ u8 rtw_get_center_ch(u8 channel, u8 chnl_bw, u8 chnl_offset);
> > unsigned long rtw_get_on_cur_ch_time(struct adapter *adapter);
> >
> > void set_channel_bwmode(struct adapter *padapter, unsigned char channel, unsigned char channel_offset, unsigned short bwmode);
> > -void SelectChannel(struct adapter *padapter, unsigned char channel);
> > +void select_channel(struct adapter *padapter, unsigned char channel);
>
> This is a pretty horrible name for a symbol in the global namespace, can
> you rename it to be more sane for this driver (i.e. put a prefix on it?)
>
> thanks,
>
> greg k-h
okay, will change and submit again.
thanks,
vivek
Powered by blists - more mailing lists