[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240828133207.493961-1-parth105105@gmail.com>
Date: Wed, 28 Aug 2024 15:32:07 +0200
From: Parth Pancholi <parth105105@...il.com>
To: Keerthy <j-keerthy@...com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>
Cc: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Parth Pancholi <parth.pancholi@...adex.com>,
stable@...r.kernel.org
Subject: [PATCH] gpio: davinci: fix lazy disable
From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
On a few platforms such as TI's AM69 device, disable_irq()
fails to keep track of the interrupts that happen between
disable_irq() and enable_irq() and those interrupts are missed.
Use the ->irq_unmask() and ->irq_mask() methods instead
of ->irq_enable() and ->irq_disable() to correctly keep track of
edges when disable_irq is called.
This solves the issue of disable_irq() not working as expected
on such platforms.
Fixes: 23265442b02b ("ARM: davinci: irq_data conversion.")
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>
Cc: stable@...r.kernel.org
---
drivers/gpio/gpio-davinci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 1d0175d6350b..0ecfa7de5ce2 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -289,7 +289,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
* serve as EDMA event triggers.
*/
-static void gpio_irq_disable(struct irq_data *d)
+static void gpio_irq_mask(struct irq_data *d)
{
struct davinci_gpio_regs __iomem *g = irq2regs(d);
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
@@ -298,7 +298,7 @@ static void gpio_irq_disable(struct irq_data *d)
writel_relaxed(mask, &g->clr_rising);
}
-static void gpio_irq_enable(struct irq_data *d)
+static void gpio_irq_unmask(struct irq_data *d)
{
struct davinci_gpio_regs __iomem *g = irq2regs(d);
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
@@ -324,8 +324,8 @@ static int gpio_irq_type(struct irq_data *d, unsigned trigger)
static struct irq_chip gpio_irqchip = {
.name = "GPIO",
- .irq_enable = gpio_irq_enable,
- .irq_disable = gpio_irq_disable,
+ .irq_unmask = gpio_irq_unmask,
+ .irq_mask = gpio_irq_mask,
.irq_set_type = gpio_irq_type,
.flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
};
--
2.34.1
Powered by blists - more mailing lists