linux-kernel - Re: [PATCH] gpio: davinci: fix lazy disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdyNFzNy_GndBDOUL23Rv0WxGG8mRd5DRD28pE=XuhfmQ@mail.gmail.com>
Date: Mon, 2 Sep 2024 14:08:30 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Parth Pancholi <parth105105@...il.com>
Cc: Keerthy <j-keerthy@...com>, Linus Walleij <linus.walleij@...aro.org>, 
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Parth Pancholi <parth.pancholi@...adex.com>, 
	stable@...r.kernel.org
Subject: Re: [PATCH] gpio: davinci: fix lazy disable

On Wed, Aug 28, 2024 at 3:32 PM Parth Pancholi <parth105105@...il.com> wrote:
>
> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
>
> On a few platforms such as TI's AM69 device, disable_irq()
> fails to keep track of the interrupts that happen between
> disable_irq() and enable_irq() and those interrupts are missed.
> Use the ->irq_unmask() and ->irq_mask() methods instead
> of ->irq_enable() and ->irq_disable() to correctly keep track of
> edges when disable_irq is called.
> This solves the issue of disable_irq() not working as expected
> on such platforms.
>
> Fixes: 23265442b02b ("ARM: davinci: irq_data conversion.")
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> Signed-off-by: Parth Pancholi <parth.pancholi@...adex.com>
> Cc: stable@...r.kernel.org
> ---

It looks good to me but I'd like to have an Ack from Keerthy on this.

Bart