linux-kernel - Re: [PATCH RFC/RFT net-next] net: stmmac: drop the ethtool begin() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ibna42mzj4tk3kddnnzgosglumngupdwxnthkm7rkqrejbr5oy@7j4ey2gtl6zl>
Date: Thu, 29 Aug 2024 08:14:43 -0500
From: Andrew Halaney <ahalaney@...hat.com>
To: Dmitry Dolenko <d.dolenko@...rotek.ru>
Cc: alexandre.torgue@...s.st.com, davem@...emloft.net, edumazet@...gle.com, 
	joabreu@...opsys.com, kuba@...nel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	mcoquelin.stm32@...il.com, netdev@...r.kernel.org, pabeni@...hat.com, 
	quic_abchauha@...cinc.com, quic_scheluve@...cinc.com, system@...rotek.ru
Subject: Re: [PATCH RFC/RFT net-next] net: stmmac: drop the ethtool begin()
 callback

On Wed, Aug 28, 2024 at 05:35:41PM GMT, Dmitry Dolenko wrote:
> Are there any updates on this topic?
> 
> We are faced with the fact that we can not read or change settings of
> interface while it is down, and came up with the same solution for this
> problem.
> 
> I do not know if Reviewed-by and Tested-by are suitable for patch marked as
> RFC but I will post mine in case it is acceptable here.
> 
> Reviewed-by: Dmitry Dolenko <d.dolenko@...rotek.ru>
> Tested-by: Dmitry Dolenko <d.dolenko@...rotek.ru>
> 

In my opinion the tags are welcomed.

I had sort of forgotten about this until your reply, the use case I
had was only to try and force out another bug, so it slipped my mind.

Since both of us were bitten by this, and nobody has indicated it's a bad
idea otherwise, I'll rebase and send v2 with your tags to try and get
this merged.

Thanks,
Andrew