linux-kernel - Re: [PATCH v3 2/2] clk: qcom: gcc-sm8550: Don't use shared clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtB_e3EgWUYtdGgV@hovoldconsulting.com>
Date: Thu, 29 Aug 2024 16:02:35 +0200
From: Johan Hovold <johan@...nel.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, patches@...ts.linux.dev,
	linux-clk@...r.kernel.org,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Amit Pundir <amit.pundir@...aro.org>,
	Taniya Das <quic_tdas@...cinc.com>
Subject: Re: [PATCH v3 2/2] clk: qcom: gcc-sm8550: Don't use shared clk_ops
 for QUPs

On Wed, Aug 28, 2024 at 10:17:08AM -0700, Stephen Boyd wrote:
> The QUPs aren't shared in a way that requires parking the RCG at an
> always on parent in case some other entity turns on the clk. The
> hardware is capable of setting a new frequency itself with the DFS mode,
> so parking is unnecessary. Furthermore, there aren't any GDSCs for these
> devices, so there isn't a possibility of the GDSC turning on the clks
> for housekeeping purposes.
> 
> This wasn't a problem to mark these clks shared until we started parking
> shared RCGs at clk registration time in commit 01a0a6cc8cfd ("clk: qcom:
> Park shared RCGs upon registration"). Parking at init is actually
> harmful to the UART when earlycon is used. If the device is pumping out
> data while the frequency changes you'll see garbage on the serial
> console until the driver can probe and actually set a proper frequency.
> 
> Revert the QUP part of commit 929c75d57566 ("clk: qcom: gcc-sm8550: Mark
> RCGs shared where applicable") so that the QUPs don't get parked during
> clk registration and break UART operations.

So this one doesn't really fix anything after patch 1/2 in v3, so
perhaps you can rephrase and drop "break UART operations" here.
 
> Fixes: 01a0a6cc8cfd ("clk: qcom: Park shared RCGs upon registration")

And drop this.

> Fixes: 929c75d57566 ("clk: qcom: gcc-sm8550: Mark RCGs shared where applicable")
> Cc: Konrad Dybcio <konradybcio@...nel.org>
> Cc: Bjorn Andersson <andersson@...nel.org>
> Cc: Taniya Das <quic_tdas@...cinc.com>
> Cc: Neil Armstrong <neil.armstrong@...aro.org>

> Reported-by: Amit Pundir <amit.pundir@...aro.org>
> Closes: https://lore.kernel.org/CAMi1Hd1KQBE4kKUdAn8E5FV+BiKzuv+8FoyWQrrTHPDoYTuhgA@mail.gmail.com

And possibly these two as well.

> Tested-by: Amit Pundir <amit.pundir@...aro.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Johan