linux-kernel - Re: [PATCH v6 2/2] dt-bindings: rtc: Add support for SD2405AL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240829-reissue-curtsy-3c7c10d0797f@spud>
Date: Thu, 29 Aug 2024 17:03:58 +0100
From: Conor Dooley <conor@...nel.org>
To: gomba007@...il.com
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-rtc@...r.kernel.org, csokas.bence@...lan.hu,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v6 2/2] dt-bindings: rtc: Add support for SD2405AL.

On Thu, Aug 29, 2024 at 01:31:45PM +0200, Tóth János via B4 Relay wrote:
> From: Tóth János <gomba007@...il.com>
> 
> Add the necessary documentation for SD2405AL.
> 
> Signed-off-by: Tóth János <gomba007@...il.com>
> ---
>  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++

Both of these should really be two different patches, despite how
trivial they would be. If you resubmit, please do that and provide a
link to the vendor in the vendor-prefixes patch. Otherwise,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> index fffd759c603f..dae594626b2e 100644
> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> @@ -38,6 +38,8 @@ properties:
>        - dallas,ds1672
>        # Extremely Accurate I²C RTC with Integrated Crystal and SRAM
>        - dallas,ds3232
> +      # SD2405AL Real-Time Clock
> +      - dfrobot,sd2405al
>        # EM Microelectronic EM3027 RTC
>        - emmicro,em3027
>        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index a70ce43b3dc0..bd8b279a5152 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -368,6 +368,8 @@ patternProperties:
>      description: Devantech, Ltd.
>    "^dfi,.*":
>      description: DFI Inc.
> +  "^dfrobot,.*":
> +    description: DFRobot Corporation
>    "^dh,.*":
>      description: DH electronics GmbH
>    "^difrnce,.*":
> 
> -- 
> 2.34.1
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)