linux-kernel - Re: [PATCH v6 0/2] Add support for the DFRobot SD2405AL I2C RTC Module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408291617526e31318b@mail.local>
Date: Thu, 29 Aug 2024 18:17:52 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: gomba007@...il.com
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-rtc@...r.kernel.org, csokas.bence@...lan.hu,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v6 0/2] Add support for the DFRobot SD2405AL I2C RTC
 Module.

This looks good, can you send v7 adressint Conor's comment, don't forget
to collect his tag.

On 29/08/2024 13:31:43+0200, Tóth János via B4 Relay wrote:
> This patch series adds a driver and the documentation for the SD2405AL I2C RTC.
> 
> To: Alexandre Belloni <alexandre.belloni@...tlin.com>
> To: Rob Herring <robh@...nel.org>
> To: Krzysztof Kozlowski <krzk+dt@...nel.org>
> To: Conor Dooley <conor+dt@...nel.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-rtc@...r.kernel.org
> Cc: csokas.bence@...lan.hu
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Tóth János <gomba007@...il.com>
> 
> Changes in v6:
> - Add missing To-s and Cc-s.
> - Rebased onto v6.11-rc5
> - Link to v5: https://lore.kernel.org/r/20240828-rtc-sd2405al-v5-0-9e3f8fa5ea6b@gmail.com
> 
> Changes in v5:
> - Rework based on Alexandre Belloni's suggestions.
> - Drop explicit initialization of struct i2c_device_id::driver_data.
> - Add documentation.
> - Link to v4: https://lore.kernel.org/r/20240624-rtc-sd2405al-v4-1-2b2bc759f98f@gmail.com
> 
> Changes in v4:
> - Implement more comprehensive data validation.
> - Inline some temporary variables.
> - Link to v3: https://lore.kernel.org/r/20240620-rtc-sd2405al-v3-1-65d5bb01af50@gmail.com
> 
> Changes in v3:
> - #define-s of registers are reworked.
> - Minor revisions based on the reviewer's suggestions.
> - Link to v2: https://lore.kernel.org/r/20240619-rtc-sd2405al-v2-1-39bea29bd2a5@gmail.com
> 
> Changes in v2:
> - Refactored based on reviewer's suggestions.
> - I couldn't get the I2C IRQ to work on Raspberry Pi 4, so alarm is
>   skipped.
> - Link to v1: https://lore.kernel.org/r/20240607-rtc-sd2405al-v1-1-535971e7a866@gmail.com
> 
> ---
> Tóth János (2):
>       drivers: rtc: Add driver for SD2405AL.
>       dt-bindings: rtc: Add support for SD2405AL.
> 
>  .../devicetree/bindings/rtc/trivial-rtc.yaml       |   2 +
>  .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
>  MAINTAINERS                                        |   6 +
>  drivers/rtc/Kconfig                                |  10 +
>  drivers/rtc/Makefile                               |   1 +
>  drivers/rtc/rtc-sd2405al.c                         | 227 +++++++++++++++++++++
>  6 files changed, 248 insertions(+)
> ---
> base-commit: 5be63fc19fcaa4c236b307420483578a56986a37
> change-id: 20240607-rtc-sd2405al-a0947377c73d
> 
> Best regards,
> -- 
> Tóth János <gomba007@...il.com>
> 
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com