linux-kernel - Re: [PATCH] usb: xHCI: add XHCI_RESET_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240829165124.GA66576@bhelgaas>
Date: Thu, 29 Aug 2024 11:51:24 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Sergei Shtylyov <sergei.shtylyov@...il.com>
Cc: WangYuli <wangyuli@...ontech.com>, mathias.nyman@...el.com,
	gregkh@...uxfoundation.org, bhelgaas@...gle.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, guanwentao@...ontech.com,
	zhanjun@...ontech.com, Chen Baozi <chenbaozi@...tium.com.cn>,
	Wang Zhimin <wangzhimin1179@...tium.com.cn>,
	Chen Zhenhua <chenzhenhua@...tium.com.cn>,
	Wang Yinfeng <wangyinfeng@...tium.com.cn>,
	Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
Subject: Re: [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium
 xHCI host

On Thu, Aug 29, 2024 at 12:38:58PM +0300, Sergei Shtylyov wrote:
> On 8/29/24 10:30 AM, WangYuli wrote:
> > +	if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM ||
> 
>    Hm, ||, not &&?
> 
> > +	    pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
> > +		xhci->quirks |= XHCI_RESET_ON_RESUME;

Definitely a bug, thanks for spotting it!  Must check both Vendor
*and* Device ID.  There are likely unrelated devices from other
vendors using the PCI_DEVICE_ID_PHYTIUM_XHCI Device ID value.