linux-kernel - Re: [PATCH] usb: xHCI: add XHCI_RESET_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99754b01-51a0-29d3-6022-4e25130ff36a@gmail.com>
Date: Thu, 29 Aug 2024 12:38:58 +0300
From: Sergei Shtylyov <sergei.shtylyov@...il.com>
To: WangYuli <wangyuli@...ontech.com>, mathias.nyman@...el.com,
 gregkh@...uxfoundation.org, bhelgaas@...gle.com
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, guanwentao@...ontech.com, zhanjun@...ontech.com,
 Chen Baozi <chenbaozi@...tium.com.cn>,
 Wang Zhimin <wangzhimin1179@...tium.com.cn>,
 Chen Zhenhua <chenzhenhua@...tium.com.cn>,
 Wang Yinfeng <wangyinfeng@...tium.com.cn>,
 Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
Subject: Re: [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium
 xHCI host

On 8/29/24 10:30 AM, WangYuli wrote:

> The resume operation of Phytium Px210 xHCI host would failed

   Fail?

> to restore state. Use the XHCI_RESET_ON_RESUME quirk to skip
> it and reset the controller after resume.
> 
> Co-developed-by: Chen Baozi <chenbaozi@...tium.com.cn>
> Signed-off-by: Chen Baozi <chenbaozi@...tium.com.cn>
> Co-developed-by: Wang Zhimin <wangzhimin1179@...tium.com.cn>
> Signed-off-by: Wang Zhimin <wangzhimin1179@...tium.com.cn>
> Co-developed-by: Chen Zhenhua <chenzhenhua@...tium.com.cn>
> Signed-off-by: Chen Zhenhua <chenzhenhua@...tium.com.cn>
> Co-developed-by: Wang Yinfeng <wangyinfeng@...tium.com.cn>
> Signed-off-by: Wang Yinfeng <wangyinfeng@...tium.com.cn>
> Co-developed-by: Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
> Signed-off-by: Jiakun Shuai <shuaijiakun1288@...tium.com.cn>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
[...]

> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index b5705ed01d83..af967644489c 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -55,6 +55,8 @@
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI		0x51ed
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed
>  
> +#define PCI_DEVICE_ID_PHYTIUM_XHCI			0xdc27
> +
>  /* Thunderbolt */
>  #define PCI_DEVICE_ID_INTEL_MAPLE_RIDGE_XHCI		0x1138
>  #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_XHCI	0x15b5
> @@ -407,6 +409,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  	if (pdev->vendor == PCI_VENDOR_ID_VIA)
>  		xhci->quirks |= XHCI_RESET_ON_RESUME;
>  
> +	if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM ||

   Hm, ||, not &&?

> +	    pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
> +		xhci->quirks |= XHCI_RESET_ON_RESUME;
> +
>  	/* See https://bugzilla.kernel.org/show_bug.cgi?id=79511 */
>  	if (pdev->vendor == PCI_VENDOR_ID_VIA &&
>  			pdev->device == 0x3432)
[...]

MBR, Sergey