linux-kernel - Re: [PATCH] interconnect: qcom: icc-rpmh: probe defer incase of missing QoS clock dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xny4v2twbt5sjjtc5yoffpnymryfd6da6pirlmiii5txyz7rl5@xy7wdrzi5auc>
Date: Thu, 29 Aug 2024 12:39:19 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
Cc: Georgi Djakov <djakov@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Jeff Johnson <quic_jjohnson@...cinc.com>, 
	quic_mdtipton@...cinc.com, quic_okukatla@...cinc.com, linux-arm-msm@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: probe defer incase of
 missing QoS clock dependency

On Tue, Aug 27, 2024 at 05:25:24PM GMT, Raviteja Laggyshetty wrote:
> Return -EPROBE_DEFER from interconnect provider incase probe defer is
> received from devm_clk_bulk_get_all(). This would help in reattempting
> the inteconnect driver probe, once the required QoS clocks are
> available.
> Rename qos_clks_required flag to qos_requires_clocks in qcom_icc_desc
> structure. This flag indicates that interconnect provider requires
> clocks for programming QoS.

Two separate commits, please.

> 
> Suggested-by: Bjorn Andersson <andersson@...nel.org>
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
> ---
>  drivers/interconnect/qcom/icc-rpmh.c | 10 +++++++---
>  drivers/interconnect/qcom/icc-rpmh.h |  2 +-
>  drivers/interconnect/qcom/sc7280.c   |  4 ++--
>  3 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
> index f49a8e0cb03c..5417abf59e28 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.c
> +++ b/drivers/interconnect/qcom/icc-rpmh.c
> @@ -311,9 +311,13 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
>  		}
>  
>  		qp->num_clks = devm_clk_bulk_get_all(qp->dev, &qp->clks);
> -		if (qp->num_clks < 0 || (!qp->num_clks && desc->qos_clks_required)) {
> -			dev_info(dev, "Skipping QoS, failed to get clk: %d\n", qp->num_clks);
> -			goto skip_qos_config;
> +		if (qp->num_clks < 0 || (!qp->num_clks && desc->qos_requires_clocks)) {
> +			if (qp->num_clks != -EPROBE_DEFER) {

if (qp->num_clks == -EPROBE_DEFER)
    return dev_err_probe(....)

if (qp->num_clks < 0 || ....)
    ....

> +				dev_info(dev, "Skipping QoS, failed to get clk: %d\n",
> +						qp->num_clks);
> +				goto skip_qos_config;
> +			}
> +			return qp->num_clks;


-- 
With best wishes
Dmitry