linux-kernel - Re: [PATCH] interconnect: qcom: icc-rpmh: probe defer incase of missing QoS clock dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9425927-c9d8-4988-8bdb-2def8d9668ca@quicinc.com>
Date: Tue, 3 Sep 2024 15:27:02 +0530
From: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Georgi Djakov <djakov@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
        Jeff Johnson <quic_jjohnson@...cinc.com>, <quic_mdtipton@...cinc.com>,
        <quic_okukatla@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bjorn Andersson
	<andersson@...nel.org>
Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: probe defer incase of
 missing QoS clock dependency


On 8/29/2024 3:09 PM, Dmitry Baryshkov wrote:
> On Tue, Aug 27, 2024 at 05:25:24PM GMT, Raviteja Laggyshetty wrote:
>> Return -EPROBE_DEFER from interconnect provider incase probe defer is
>> received from devm_clk_bulk_get_all(). This would help in reattempting
>> the inteconnect driver probe, once the required QoS clocks are
>> available.
>> Rename qos_clks_required flag to qos_requires_clocks in qcom_icc_desc
>> structure. This flag indicates that interconnect provider requires
>> clocks for programming QoS.
> Two separate commits, please.

Thanks for the review, I will address the comment in next patch revision.  I will post a new patch for renaming "qos_clks_required" flag.

>
>> Suggested-by: Bjorn Andersson <andersson@...nel.org>
>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
>> ---
>>  drivers/interconnect/qcom/icc-rpmh.c | 10 +++++++---
>>  drivers/interconnect/qcom/icc-rpmh.h |  2 +-
>>  drivers/interconnect/qcom/sc7280.c   |  4 ++--
>>  3 files changed, 10 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
>> index f49a8e0cb03c..5417abf59e28 100644
>> --- a/drivers/interconnect/qcom/icc-rpmh.c
>> +++ b/drivers/interconnect/qcom/icc-rpmh.c
>> @@ -311,9 +311,13 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
>>  		}
>>  
>>  		qp->num_clks = devm_clk_bulk_get_all(qp->dev, &qp->clks);
>> -		if (qp->num_clks < 0 || (!qp->num_clks && desc->qos_clks_required)) {
>> -			dev_info(dev, "Skipping QoS, failed to get clk: %d\n", qp->num_clks);
>> -			goto skip_qos_config;
>> +		if (qp->num_clks < 0 || (!qp->num_clks && desc->qos_requires_clocks)) {
>> +			if (qp->num_clks != -EPROBE_DEFER) {
> if (qp->num_clks == -EPROBE_DEFER)
>     return dev_err_probe(....)
Will address this comment in next patch revision.
> if (qp->num_clks < 0 || ....)
>     ....
>
>> +				dev_info(dev, "Skipping QoS, failed to get clk: %d\n",
>> +						qp->num_clks);
>> +				goto skip_qos_config;
>> +			}
>> +			return qp->num_clks;
>