linux-kernel - Re: [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtCp346ucJq/V1kP@vaman>
Date: Thu, 29 Aug 2024 22:33:27 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Inochi Amaoto <inochiama@...look.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Chen Wang <unicorn_wang@...look.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, dmaengine@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for
 CV18XX/SG200X

On 29-08-24, 09:38, Inochi Amaoto wrote:
> On Wed, Aug 28, 2024 at 11:24:24PM GMT, Vinod Koul wrote:
> > On 27-08-24, 14:49, Inochi Amaoto wrote:
> > > The "top" system controller of CV18XX/SG200X exposes control
> > > register access for various devices. Add soc header file to
> > > describe it.
> > 
> > I dont think I am full onboard this idea, 
> 
> Feel free to share your idea. I just added this file for
> convenience to access the offset of the syscon device. 
> In fact, I am not sure whether it is better to use reg
> offset. Using reg adds some unncessary complexity, but
> can avoid use this offset file. If you prefer this way,
> it is OK for me to change.

I would just add the offsets that I need in local driver header and move
on...

> 
> > but still need someone to ack it
> 
> I am not sure there will be someone to ack it. If this patch
> is kept.
> 
> > > 
> > > Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> > > ---
> > >  include/soc/sophgo/cv1800-sysctl.h | 30 ++++++++++++++++++++++++++++++
> > 
> > is soc/sophgo/ right path? why not include/soc/sifive/... (sorry dont
> > know much about this here...)
> > 
> 
> CV1800 is a SoC from Sophgo, it is not from SiFive.

As I said I am not sure, someone who is from this world should ack this
header

-- 
~Vinod