linux-kernel - Re: [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB49538735A53766A62553FEF0BB972@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Fri, 30 Aug 2024 09:30:24 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Vinod Koul <vkoul@...nel.org>, Inochi Amaoto <inochiama@...look.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, dmaengine@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v12 2/3] soc/sophgo: add top sysctrl layout file for
 CV18XX/SG200X

On Thu, Aug 29, 2024 at 10:33:27PM GMT, Vinod Koul wrote:
> On 29-08-24, 09:38, Inochi Amaoto wrote:
> > On Wed, Aug 28, 2024 at 11:24:24PM GMT, Vinod Koul wrote:
> > > On 27-08-24, 14:49, Inochi Amaoto wrote:
> > > > The "top" system controller of CV18XX/SG200X exposes control
> > > > register access for various devices. Add soc header file to
> > > > describe it.
> > > 
> > > I dont think I am full onboard this idea, 
> > 
> > Feel free to share your idea. I just added this file for
> > convenience to access the offset of the syscon device. 
> > In fact, I am not sure whether it is better to use reg
> > offset. Using reg adds some unncessary complexity, but
> > can avoid use this offset file. If you prefer this way,
> > it is OK for me to change.
> 
> I would just add the offsets that I need in local driver header and move
> on...
> 

Yeah, this is a solution. I think I should take it.
After rechecking the headers in the include/soc/.
I think I may make a mistake.

Regards,
Inochi